chore: consolidate dependabot PRs and update all packages to latest - #394
Conversation
|
@copilot did we use npm to update our packages? Looks like our lock file is out of date in CI. Also update our code if we needed to from the package upgrades |
Done in commit Lock files: Ran Code fixes required by the upgrades:
|
…latest Co-authored-by: BenjaminMichaelis <[email protected]>
bb615ea to
51ae548
Compare
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
There was a problem hiding this comment.
Pull request overview
Consolidates multiple Dependabot updates into a single dependency-refresh PR across the repo’s .NET (central package management), JavaScript workspaces (npm), and GitHub Actions lockfile, aiming to bring packages up to their latest versions.
Changes:
- Updates npm devDependencies/dependencies across
microsoft-trydotnet,microsoft-trydotnet-editor,microsoft-learn-mock, andmicrosoft-trydotnet-styles(including major bumps like TypeScript 7, eslint 10, rollup 4, monaco 0.56). - Bumps central NuGet package versions in
Directory.Packages.props(notablySystem.Reactive7.0.0 and Blazor WebAssembly packages 10.0.10). - Updates the pinned
actions/checkoutSHA in the Dependabot major-review workflow lockfile.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/microsoft-trydotnet/package.json | Bumps TypeScript/jsdom/@types to newer versions for the trydotnet JS package. |
| src/microsoft-trydotnet/package-lock.json | Refreshes the resolved dependency graph for the trydotnet JS package to match updated deps. |
| src/microsoft-trydotnet-styles/package.json | Updates sass version range for the styles package. |
| src/microsoft-trydotnet-editor/package.json | Major bumps for TypeScript/eslint and runtime deps like monaco/polyglot-notebooks/uuid. |
| src/microsoft-learn-mock/package.json | Major bumps for rollup and TypeScript in the learn-mock package. |
| Directory.Packages.props | Centralized NuGet version bumps for .NET projects. |
| .github/workflows/dependabot-major-review.lock.yml | Updates pinned actions/checkout reference to v7.0.1 SHA. |
Files not reviewed (1)
- src/microsoft-trydotnet/package-lock.json: Generated file
Suppressed comments (1)
src/microsoft-trydotnet/package-lock.json:3802
- This lockfile update pulls in
[email protected], which requires Node>=22.19.0(engines field). CI currently runsnpm ciunder Node 20 (.github/actions/setup-node/action.yml:14), so the dependency graph is not runnable in CI as-is.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Upgrade CI setup-node to Node 22 (jsdom@29+ and undici@8 require >=22) - Pin jsdom to 29.1.1 in microsoft-trydotnet (30.x requires Node 22.22+) - Pin typescript to ^5.9.3 in microsoft-trydotnet-editor (@typescript-eslint <6.1.0) - Pin @types/chai to 5.0.1 in editor (@types/chai-subset peer requires <5.2.0) - Regenerate package-lock.json for both packages
…g overhaul) Monaco 0.56 has breaking webpack changes (nls.messages-loader) that require significant webpack configuration updates. Keeping 0.33.0 maintains stability and matches main branch. This PR is about consolidating dependabot updates, not major version changes.
TypeScript couldn't resolve Buffer (from workspace.ts) or util module (from @microsoft/polyglot-notebooks) because tsconfig had types: [] which disabled all type definitions. Added types: ['node'] to include Node.js type definitions.
…Node 24 LTS - Pin typescript to ^5.9.3 in microsoft-learn-mock to match trydotnet/editor (rollup-plugin-typescript2 incompatible with TS 6+) - Fix rollup.config.js to use createRequire for package.json import (Node 20 compat) - Upgrade CI setup-node from Node 22 → 24 LTS - Regenerate package-lock.json files - All four packages now pass buildProd locally
…sembly The VersionOverride=10.0.5 was causing a NuGet package downgrade error (NU1605) because Microsoft.AspNetCore.Components.WebAssembly.Server 10.0.10 requires version >= 10.0.10 of its dependency. The central package management (Directory.Packages.props) now specifies 10.0.10, so the override is no longer needed and was creating an irreconcilable conflict. Fixes: NuGet restore errors in build-and-test, build-and-test-windows, copilot-setup-steps, and integration-tests jobs. Co-authored-by: Copilot <[email protected]>
- Create eslint.config.js with flat config format required by ESLint 9.0.0+ - Remove obsolete .eslintrc.json (replaced by flat config) - Remove obsolete .eslintignore (now using 'ignores' in flat config) - Fixes ESLint failure when running npm run lint with ESLint 10.8.1 Co-authored-by: Copilot <[email protected]>
…error handling The upgrade to @microsoft/polyglot-notebooks 1.0.722201 changed how the Kernel class handles errors in async command handlers. Errors thrown in handlers are no longer automatically converted to CommandFailed events, causing the test 'cannot open document if there is no open project' to fail. This reverts @microsoft/polyglot-notebooks to the stable version 1.0.441801 that properly handles error propagation in command handlers. Fixes: Build-Test-And-Deploy failing on 'Run ciTest for microsoft-trydotnet-editor' Co-authored-by: Copilot <[email protected]>
… Docker build Co-authored-by: BenjaminMichaelis <[email protected]>
Combines 15 open dependabot PRs into a single update, bumping all outdated NuGet, npm, and GitHub Actions dependencies — including several packages beyond what dependabot had staged.
NuGet (
Directory.Packages.props)System.Reactive6.1.0 → 7.0.0Microsoft.AspNetCore.Components.WebAssembly+.Server10.0.5 → 10.0.10npm —
microsoft-trydotnetjsdom29.1.1 → 30.0.1@types/node^25.9.3 → ^26.2.0@types/chai^5.0.1 → ^5.2.3typescript^5.9.3 → ^7.0.2rollup4.62.3 → 4.62.4npm —
microsoft-trydotnet-editortypescript^5.8.3 → ^7.0.2eslint^8.57.0 → ^10.8.1uuid13.0.0 → 14.0.1@microsoft/polyglot-notebooks1.0.441801 → 1.0.722201monaco-editor0.33.0 → 0.56.0npm —
microsoft-learn-mockrollup2.79.2 → 4.62.4typescript^5.9.3 → ^7.0.2npm —
microsoft-trydotnet-stylessass^1.99.0 → ^1.102.0GitHub Actions
actions/checkoutv7.0.0 → v7.0.1 (SHA updated in lock file)